[GH-411] Dungeon supercampaign scene #478
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nment to support campaigns with different amount of levels and level indicators in scene.
ncontinanza
requested review from
AminArria,
manucamejo,
tvillegas98,
martinacantaro,
mgrunwaldt,
saugon,
marco-paulucci,
agustinesco,
tkz00,
Nico-Sanchez,
lotuuu,
AngieDutra and
alfopisano
as code owners
ncontinanza
changed the title
tkz00
requested changes
Jun 3, 2024
ncontinanza
added
the
Waiting on PR
|
Here's some easier code for fetching the user without needing to know the name! |
tkz00
reviewed
Jun 7, 2024
|
Also I think it would be nice that if a level has a max number of units, it automatically deselects the leftover units, but I believe that is a backend change. |
Yes, we'll need a PR in the backend for that to be made properly: #485 |
ncontinanza
removed
Waiting on PR
tkz00
previously approved these changes
Jun 12, 2024
lotuuu
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #411
Motivation
Connect the backend features that implement the dungeon supercampaign, its campaign and levels with our client.
Summary of changes
How has this been tested?
In order to win the dungeon levels and test all the available levels in the campaign, you may need to edit the character.csv in the backend and reduce El1xir's life to 10, so that you can easily beat it in this first level.
Checklist